sql: Exclude statements that spawn jobs from showing up in query tables.

[itsbilal]

Add a type switch for the AST, and manually exclude BACKUP/RESTORE/ALTER TABLEss from being added to session.mu.ActiveQueries, making them uncancellable and "invisible" to SHOW QUERIES.

Fixes #17730 .

[cockroach-teamcity]

This change is 

[knz]

The intention is laudable but the approach is limited. Please instead use the same approach as HiddenFromStats and IndependentFromParallelizedPriors in parser/stmt.go.

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from Reviewable

[itsbilal]

Done. Implemented a new pseudo-interface. PTAL!

---

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending.

---

Comments from Reviewable

[nvanbenschoten]

Nice improvement!

---

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

pkg/sql/executor.go, line 1097 at r2 (raw file):

		queryMeta.ctxCancel = txnState.cancel

		// Ignore statements that spawn jobs from SHOW QUERIES and from being cancellable using CANCEL QUERY.

A few long lines here. Try to keep under 100 chars, per our style guide.

---

pkg/sql/session.go, line 661 at r2 (raw file):

	queryMeta, ok := s.mu.ActiveQueries[queryID]
	if !ok {
		// Could be an ignored statement type.

Give this a bit more detail (eg. mention HiddenFromShowQueries). "ignored" could mean a lot of things.

---

pkg/sql/session.go, line 662 at r2 (raw file):

	if !ok {
		// Could be an ignored statement type.
		s.mu.Unlock()

I would just defer the Unlock at the top. We don't do anything expensive after unlocking anyway.

---

Comments from Reviewable

[itsbilal]

Review status: 1 of 3 files reviewed at latest revision, 3 unresolved discussions.

---

pkg/sql/executor.go, line 1097 at r2 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

A few long lines here. Try to keep under 100 chars, per our style guide.

Done.

---

pkg/sql/session.go, line 661 at r2 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

Give this a bit more detail (eg. mention HiddenFromShowQueries). "ignored" could mean a lot of things.

Done.

---

pkg/sql/session.go, line 662 at r2 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

I would just defer the Unlock at the top. We don't do anything expensive after unlocking anyway.

Done.

---

Comments from Reviewable

[nvanbenschoten]

---

Review status: 1 of 3 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable