parse literals more like Postgres #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| buf = append(buf, '\\') | ||
| buf = append(buf, encodedChar) | ||
| } | ||
| } | ||
| buf = append(buf, '\'') | ||
| if strMod != 0 { |
There was a problem hiding this comment.
Why don't you append the strMod byte above where the opening ' is appended?
There was a problem hiding this comment.
done. Remnants from earlier code where I hoped not to have to iterate twice.
|
LGTM |
tbg
force-pushed
the
sql_literals
branch
3 times, most recently
from
f440628
to
0c9245c
Compare
with this change * rewrote SQL escaping. It'll output an escaped string when it has to, or when a single-quote or backslash appears (the former could be written as '', but this is more awkward to implement; the latter needs escaping only in an escaped string, which would require an extra pass through the string prior to beginning the encoding - not worth it). * no escaping of "; Postgres doesn't do it * dissect and update all the test cases affected by this and add some new ones. found via go-fuzz, ping @dvyukov.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a single-quote or backslash appears (the former could be written as '', but
this is more awkward to implement; the latter needs escaping only in an
escaped string, which would require an extra pass through the string prior
to beginning the encoding - not worth it).
found via go-fuzz, ping @dvyukov.