Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick-1.1: storageccl: use the official AWS SDK #19473

Merged
merged 2 commits into from
Oct 24, 2017
Merged

cherrypick-1.1: storageccl: use the official AWS SDK #19473

merged 2 commits into from
Oct 24, 2017

Conversation

maddyblue
Copy link
Contributor

This change is similar to #18902 except that it:

  • omits the Size method and tests
  • ensures that there are no changes to vendor, only Gopkg.lock

There are various other changes in Gopkg.lock which should have
already been in 1.1, but are included here for correctness.

See #18902
Fixes #19435

@maddyblue
cherrypick-1.1: storageccl: use the official AWS SDK
2d44be8 
This change is similar to #18902 except that it:
- omits the Size method and tests
- ensures that there are no changes to vendor, only Gopkg.lock

There are various other changes in Gopkg.lock which should have
already been in 1.1, but are included here for correctness.

See #18902
Fixes #19435
@maddyblue maddyblue requested review from dt and a team October 24, 2017 01:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

dt
dt approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm (since we can't have CIs to it): did you run the s3 storageccl tests by hand against us and non-us buckets?

Gopkg.toml

[[constraint]]
name = "github.com/rlmcpherson/s3gof3r"
revision = "864ae0bf7cf2e20c0002b7ea17f4d84fec1abc14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

@maddyblue
Copy link
Contributor Author

Yes, I made a eu-west-1 bucket and ran the S3 tests on it.

@maddyblue
newline
93a8938 
will be squashed
@maddyblue maddyblue merged commit 0762c60 into cockroachdb:release-1.1 Oct 24, 2017
@maddyblue maddyblue deleted the cherrypick-18902 branch October 24, 2017 17:43
@couchand couchand mentioned this pull request Apr 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdarnell bdarnell bdarnell approved these changes

@dt dt dt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddyblue @cockroach-teamcity @dt @bdarnell