cherrypick-1.1: sqlbase: fix encoding of index value when using unspecified columns #20074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this fix we would treat an unspecified column as a NULL value when encoding a column for an index key, but not when encoding it in the index as the value part of the key:value index pair. For the storing case, we would pick up the first specified value for the unspecified value and encode it in the index creating a completely broken index! For the composite encoding case it would crash. See cockroachdb#20000 fixes cockroachdb#20000
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this fix we would treat an unspecified column as a NULL value
when encoding a column for an index key, but not when encoding it in the
index as the value part of the key:value index pair.
For the storing case, we would pick up the first specified value
for the unspecified value and encode it in the index creating a
completely broken index!
For the composite encoding case it would crash. See #20000
fixes #20000