build: interpret all protoc warnings as errors #20339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM. I'm sad to see there is no |
|
Indeed. If I had to guess, the problem is that protoc has no concept of warnings, so gogoproto prints directly to stderr: https://github.com/gogo/protobuf/blob/a11c89fbb0ad4acfa8abc4a4d5f7e27c477169b1/plugin/defaultcheck/defaultcheck.go#L102 I'll file a bug there. Thanks for the review! |
|
uggg, blocked on gogo/protobuf#207. Nothing is ever easy. |
Fix the following protobuf warning:
WARNING: field BackupDescriptor.CompleteDbs is a repeated non-nullable
native type, nullable=false has no effect
Keep protoc warnings from getting lost in the noise, like in dd588f58.
benesch
force-pushed
the
protoc-warnings
branch
from
3b8936d
to
a48f3ac
Compare
|
Well, that was a stupid amount of yak shaving. I've submitted a request for a -Werror into the upstream void (protocolbuffers/protobuf#3980), but this should do for now. TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.