release-1.1: server: Don't send pgwire connections to the init GRPC server #22663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
changed the title
a-robinson
approved these changes
Feb 15, 2018
PGWire messages do not reliably trigger errors in the HTTP server, which leads to these connections timing out (which has been observed to take minutes, depending on the client). Instead, we must always send pgwire connections to the pgwire server (where they will still block while the server is uninitialized, but they will be unblocked as soon as it initializes). This is a subset of cockroachdb#21682 for release-1.1.
bdarnell
force-pushed
the
init-listener
branch
from
e610d1b
to
ac40ef7
Compare
|
Rebased and added the init_test.go changes from #21682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGWire messages do not reliably trigger errors in the HTTP server,
which leads to these connections timing out (which has been observed
to take minutes, depending on the client). Instead, we must always
send pgwire connections to the pgwire server (where they will still
block while the server is uninitialized, but they will be unblocked
as soon as it initializes).
This is a subset of #21682 for release-1.1.