vendor: bump go.etcd.io/etcd #30443
Merged
vendor: bump go.etcd.io/etcd #30443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Sep 19, 2018
petermattis
force-pushed
the
pmattis/bump-etcd
branch
from
cc08e14
to
ba11263
Compare
This picks up etcd-io/etcd#10106 which fixes an issue where `raft.Ready.MustSync` was being set too frequently resulting in unnecessary synchronous writes to the RocksDB WAL. Release note (performance improvement): Remove unnecessary synchronous disk writes caused by erroneous logic in the Raft implementation.
petermattis
force-pushed
the
pmattis/bump-etcd
branch
from
ba11263
to
4d03a82
Compare
benesch
approved these changes
Sep 20, 2018
|
bors r=nvanbenschoten,benesch |
craig bot
pushed a commit
that referenced
this pull request
Sep 20, 2018
30443: vendor: bump go.etcd.io/etcd r=nvanbenschoten,benesch a=petermattis This picks up etcd-io/etcd#10106 which fixes an issue where `raft.Ready.MustSync` was being set too frequently resulting in unnecessary synchronous writes to the RocksDB WAL. Release note (performance improvement): Remove unnecessary synchronous disk writes caused by erroneous logic in the Raft implementation. Co-authored-by: Peter Mattis <petermattis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up etcd-io/etcd#10106 which fixes an issue where
raft.Ready.MustSyncwas being set too frequently resulting inunnecessary synchronous writes to the RocksDB WAL.
Release note (performance improvement): Remove unnecessary synchronous
disk writes caused by erroneous logic in the Raft implementation.