Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/changefeedccl: deflake TestChangefeedSchemaChangeAllowBackfill #33272

Closed
wants to merge 1 commit into from
Closed

ccl/changefeedccl: deflake TestChangefeedSchemaChangeAllowBackfill #33272

wants to merge 1 commit into from

Commits on Dec 19, 2018

  1. ccl/changefeedccl: deflake TestChangefeedSchemaChangeAllowBackfill 

    Any goroutine started via `Stopper.RunAsyncTask` needs to watch
`Stopper.ShouldQuiesce()` to determine if it should stop
processing. This wasn't being done properly for the "changefeed-poller"
task causing the test to fail to exit in rare circumstances.

Fixes cockroachdb#33166

Release note: None
    @petermattis
    petermattis committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    0b1a649 View commit details
    Browse the repository at this point in the history