roachtest: fix flakey follower read roachtest #34711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Feb 7, 2019
pkg/cmd/roachtest/follower_reads.go
Outdated
| @@ -208,7 +208,7 @@ func runFollowerReadsTest(ctx context.Context, t *test, c *cluster) { | |||
| // Run reads for 60s which given the metrics window of 10s should guarantee | |||
The follower read roachtest sustains reads against followers and verifies that the 90th %-ile latency never exceeds 20ms. During certain situations like lease transfer, the latency may jump up. This change now runs the sustained reads for longer (3 minutes instead of 1) and verifies that the latency is low at least 80% of the time. This should be much less fragile. Fixes cockroachdb#34701. Release note: None
ajwerner
force-pushed
the
ajwerner/fix-roachtest
branch
from
fbe0588
to
b490469
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 7, 2019
34711: roachtest: fix flakey follower read roachtest r=ajwerner a=ajwerner The follower read roachtest sustains reads against followers and verifies that the 90th %-ile latency never exceeds 20ms. During certain situations like lease transfer, the latency may jump up. This change now runs the sustained reads for longer (3 minutes instead of 1) and verifies that the latency is low at least 80% of the time. This should be much less fragile. Fixes #34701. Release note: None 34721: server: remove timeout from the problem ranges page r=andreimatei a=andreimatei This page was using an arbitrary timeout of 3s which was proving insufficient for a user. Not particularly surprising, since the report performs RPCs which need to iterate through all the ranges. No more timeout. Fixes #34311 Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follower read roachtest sustains reads against followers and verifies that
the 90th %-ile latency never exceeds 20ms. During certain situations like lease
transfer, the latency may jump up. This change now runs the sustained reads for
longer (3 minutes instead of 1) and verifies that the latency is low at least
80% of the time. This should be much less fragile.
Fixes #34701.
Release note: None