sql: validate computed columns during ALTER TABLE #36518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Thanks for fixing this. I see some tests failing with your change. |
Previously these were only validated during CREATE, allowing the creation of incorrect columns. validateComputedColumn has removed its dependency on the tree.CreateTable struct so that the alter code can use it. Because of this, all FKs must be computed prior to the computed validate checks. Fixes #36036 Release note (bug fix): Correctly validate computed columns during ALTER TABLE ADD COLUMN.
|
Fixed. We had a test that had enshrined the unsupported feature of computed columns depending on other computed columns. |
|
ping @vivekmenezes. I'd like to get this into 19.1. |
vivekmenezes
approved these changes
Apr 5, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 5, 2019
36518: sql: validate computed columns during ALTER TABLE r=vivekmenezes a=mjibson Previously these were only validated during CREATE, allowing the creation of incorrect columns. validateComputedColumn has removed its dependency on the tree.CreateTable struct so that the alter code can use it. Because of this, all FKs must be computed prior to the computed validate checks. Fixes #36036 Release note (bug fix): Correctly validate computed columns during ALTER TABLE ADD COLUMN. Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these were only validated during CREATE, allowing the creation
of incorrect columns. validateComputedColumn has removed its dependency
on the tree.CreateTable struct so that the alter code can use it. Because
of this, all FKs must be computed prior to the computed validate checks.
Fixes #36036
Release note (bug fix): Correctly validate computed columns during ALTER
TABLE ADD COLUMN.