tree: fix LIKE suboperator with NULL LHS #41042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a NULL value was present in the LHS of a suboperator with a LIKE comparison, then previously the server would crash with a panic. Now it is handled and there are tests. closes cockroachdb#40841 Release justification: Low impact bug fix that prevents a server crash. Release note: None
|
This change is |
jordanlewis
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto and @jordanlewis)
|
thanks for triaging + reviewing! i will backport this to 19.1 as well bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
41037: stats: add logging to TestDefaultColumns to help debug flake r=rytaft a=rytaft This commit adds some logging to the `TestDefaultColumns` test in order to help debug a test failure. Informs #38572 Release note: None Release justification: category 1, non-production code change 41042: tree: fix LIKE suboperator with NULL LHS r=rafiss a=rafiss If a NULL value was present in the LHS of a suboperator with a LIKE comparison, then previously the server would crash with a panic. Now it is handled and there are tests. closes #40841 Release justification: Low impact bug fix that prevents a server crash. Release note: None Co-authored-by: Rebecca Taft <becca@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a NULL value was present in the LHS of a suboperator with a LIKE
comparison, then previously the server would crash with a panic. Now it
is handled and there are tests.
closes #40841
Release justification: Low impact bug fix that prevents a server crash.
Release note: None