server: avoid considering non-authenticated reqs as root-authenticated #45125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45018.
First commit from #45119.
Prior to this patch, the impl code for the various RPCs
were assuming that the lack of a username in their incoming context
implied that the connection necessarily had already been
authenticated for the
root
user.This assumption does not seem to be substantiated anywhere.
Even if the current structure of the code may have made this true
by accident, there is no guardrail that enforces it.
This patch rectifies the situation by lifting the assumption.
This changes the requirement for the conn acceptors to always
populate the username metadata.
Release note: None