release-21.1: sql: Fix panic when transitioning from REGIONAL BY ROW #62034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the transition from REGIONAL BY ROW to REGIONAL BY TABLE would drop the partitioning on the table not drop the zone configurations. As a result, when the index GC runs, it would try and cleanup the zone configurations. This hit an issue though, as the types are not properly hydrated in the index GC code path. The end result was that the index GC would panic and bring down the node. To work around this problem this commit adds code to remove the zone configs when dropping the table partitioning. Note: This commit does not solve the root cause of this issue, but instead, prevent the failure from occurring when transitioning from REGIONAL BY ROW tables to REGIONAL BY TABLE tables. A new issue will be opened for the general problem. Release note: None
|
This change is |
otan
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #61889.
/cc @cockroachdb/release
Before this commit, the transition from REGIONAL BY ROW to REGIONAL
BY TABLE would drop the partitioning on the table not drop the
zone configurations. As a result, when the index GC runs, it would
try and cleanup the zone configurations. This hit an issue though,
as the types are not properly hydrated in the index GC code path.
The end result was that the index GC would panic and bring down the
node. To work around this problem this commit adds code to remove
the zone configs when dropping the table partitioning.
Note: This commit does not solve the root cause of this issue, but
instead, prevent the failure from occurring when transitioning from
REGIONAL BY ROW tables to REGIONAL BY TABLE tables. A new issue
will be opened for the general problem.
Release note: None
Resolves #61751 .