sql: Add support for floor division

[nvanbenschoten]

See #6369.

This change adds the syntax // for floor division.

---

This change is

[knz]

LGTM, but I was imagining more an overloaded operator. x // y where x and y are decimals should produce decimal, just one there the decimal part is all zeros. Same for floats.

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

sql: Add support for integer division

See #6369.

This change adds the syntax // for integer division.

---

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from Reviewable

[bdarnell]

Yeah, in python // is called "floor division" instead of "integer division" because it's equivalent to floor(x/y) cast to the type of the inputs.

Previously, knz (kena) wrote…

LGTM, but I was imagining more an overloaded operator. x // y where x and y are decimals should produce decimal, just one there the decimal part is all zeros. Same for floats.

---

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

sql/parser/scan.go, line 330 [r1] (raw file):

  case '/':
      switch s.peek() {
      case '/': // //

Nice comment :)

---

Comments from Reviewable

[nvanbenschoten]

Updated to support floor division with all three numeric data types. I also had to change a few tests now that DECIMAL is the default numeric data type. PTAL

Previously, bdarnell (Ben Darnell) wrote…

Yeah, in python // is called "floor division" instead of "integer division" because it's equivalent to floor(x/y) cast to the type of the inputs.

---

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

sql/parser/scan.go, line 330 [r1] (raw file):

Previously, bdarnell (Ben Darnell) wrote…

Nice comment :)

I'm pretty proud of that one.

---

Comments from Reviewable

[nvanbenschoten]

Does this still look good after the support for FLOAT and DECIMAL?