Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingccl: fix test flakes #69073

Closed
wants to merge 2 commits into from
Closed

Conversation

annezhu98
Copy link

@annezhu98 annezhu98 commented Aug 18, 2021

Fix TestStreamIngestionFrontierProcessor and TestStreamIngestionProcessor.

Informs: #68701, #68704

Add `GenerationEvent` as a possible event type to be emitted over a cluster stream. When a `GenerationEvent` is emitted, we should be able to get its topology as well as the start time of the new generation.

Release note: None
@annezhu98 annezhu98 requested review from adityamaru and a team August 18, 2021 03:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

…am client

Previously, if the sinkless client loses connection, the processor would receive an error and move to draining. With the concept of generation, the sinkless client should send over a `GenerationEvent` once it has lost connection. On receiving a `GenerationEvent`, the processor should wait for a cutover signal to be sent (the mechanism for issuing cutover signals on new generation will be implemented in a following PR).

Release note: None
@annezhu98
Copy link
Author

annezhu98 commented Aug 19, 2021

TestStreamIngestionFrontierProcessor seems to be deflaked.

@adityamaru
Copy link
Contributor

Closing in favour of #69262.

@adityamaru adityamaru closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants