streamingccl: unskip TestStreamIngestionFrontierProcessor #70513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test does not flake anymore. There have been fixes around leaked goroutines that have been checked in in the recent past but the test mistakenly remained skipped: cockroachdb#69262 I got 3000 runs under stress. Fixes: cockroachdb#68704
adityamaru
requested review from
rhu713,
a team and
shermanCRL
and removed request for
a team
|
This change is |
|
Friendly ping @rhu713 🙂 |
rhu713
approved these changes
Sep 28, 2021
|
TFTR! bors r=rhu713 |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test does not flake anymore. There have been fixes around
leaked goroutines that have been checked in in the recent past
but the test mistakenly remained skipped:
#69262
I got 3000 runs under stress.
Fixes: #68704