Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: set range tombstones flag accordingly #96964

Merged
merged 1 commit into from
Feb 10, 2023
Merged

roachtest: set range tombstones flag accordingly #96964

merged 1 commit into from
Feb 10, 2023

Conversation

nicktrav
Copy link
Collaborator

@nicktrav nicktrav commented Feb 10, 2023 •
edited
Loading

Fix a bug in the import-cancellation roachtest whereby range tombstones are always disabled.

Release note: None.

Epic: CRDB-20465

@nicktrav
roachtest: set range tombstones flag accordingly
8cc347b 
Fix a bug in the `import-cancellation` roachtest whereby range
tombstones are always disabled.

Release note: None.
@nicktrav nicktrav requested review from jbowens and a team February 10, 2023 17:35
@nicktrav nicktrav requested a review from a team as a code owner February 10, 2023 17:35
@nicktrav nicktrav requested review from herkolategan and srosenberg and removed request for a team February 10, 2023 17:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav
Copy link
Collaborator Author

I'm going to rip this out entirely as part of #91147. However, I'd like to backport this particular fix for the 22.2.x branch.

jbowens
jbowens approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@jbowens jbowens left a comment •
edited by cockroach-dev-inf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nicktrav
Copy link
Collaborator Author

TFTRs!

bors r=jbowens,msbutler

@craig
Copy link
Contributor

craig bot commented Feb 10, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 10, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 10, 2023

Build succeeded:

@craig craig bot merged commit 8c2060c into cockroachdb:master Feb 10, 2023
@blathers-crl blathers-crl bot mentioned this pull request Feb 10, 2023
Merged
@nicktrav nicktrav deleted the nickt.import-cancellation-fix branch February 11, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbutler msbutler msbutler approved these changes

@jbowens jbowens jbowens approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicktrav @cockroach-teamcity @jbowens @msbutler