Skip to content

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented Jan 18, 2017

This PR adds a note to the top of the full SQL grammar page encouraging users to checkout the statement-specific pages first.

It also adds a link to the warning in the beta-20170112 release notes.

Fixes #1013


This change is Reviewable

@cockroach-teamcity
Copy link
Member

sql-grammar.md Outdated
}
</style>

{{site.data.alerts.callout_success}}This page describes the full CockroachDB SQL grammar. However, as a starting point, it's best to reference our <a href="sql-statements.html">statement-specific pages</a> first, which provide detailed explanations and examples.{{site.data.alerts.end}}
Copy link
Contributor

@maddyblue maddyblue Jan 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a markdown link: [statement-specific pages](sql-statements.html)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As our alerts are currently set up, you have to use html formatting inside them. There's a way to enable markdown inside html, though (an extra attribute). Let me see if that works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that adding markdown="1" to the the relevant alert divs in _data\alerts.yml does let us use markdown formatting within alerts. One gotcha though is that the liquid before and after an alert needs to be on its own line. I'll update our internal docs on this.

@cockroach-teamcity
Copy link
Member

callout_success: '<div class="bs-callout bs-callout-success">'
callout_info: '<div class="bs-callout bs-callout-info">'
callout_warning: '<div class="bs-callout bs-callout-warning">'
callout_danger: '<div class="bs-callout bs-callout-danger" markdown="1">'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know you had to add this stuff :( Thanks for figuring that out though.

@jseldess jseldess merged commit d3f9c83 into gh-pages Jan 18, 2017
@jseldess jseldess deleted the note-on-grammar branch January 18, 2017 22:31
Simran-B pushed a commit to Simran-B/docs that referenced this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants