Update SHOW ALL docs and sidebar #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvb
reviewed
Feb 1, 2017
show-all.md
Outdated
| `DATABASE` | The default database for the current session, as set by [`SET DATABASE`](set-database.html) or the client's connection string. This variable can be viewed with [`SHOW DATABASE`](show-database.html) as well. | ||
| `DEFAULT_TRANSACTION_ISOLATION` | The default transaction isolation level for the current session, as set by `SET DEFAULT_TRANSACTION_ISOLATION` or the client's connection string. | ||
| `MAX_INDEX_KEYS` | Not usable; exposed only for ORM compatibility. | ||
| `SEARCH_PATH` | A list of databases or name spaces that will be searched to resolve unqualified table or function names. This variable can be changed with `SET SEARCH_PATH`. |
There was a problem hiding this comment.
Namespaces should be a single word.
Also, we don't actually support changing this with SET, so I would drop the last sentence.
show-all.md
Outdated
| `DEFAULT_TRANSACTION_ISOLATION` | The default transaction isolation level for the current session, as set by `SET DEFAULT_TRANSACTION_ISOLATION` or the client's connection string. | ||
| `MAX_INDEX_KEYS` | Not usable; exposed only for ORM compatibility. | ||
| `SEARCH_PATH` | A list of databases or name spaces that will be searched to resolve unqualified table or function names. This variable can be changed with `SET SEARCH_PATH`. | ||
| `SERVER_VERSION` | The latest version of PostgreSQL that CockroachDB is compatible with. |
There was a problem hiding this comment.
I'm starting to doubt that "compatible with" is the correct phrasing, and I would drop the word "latest". This is the version of Postgres that we try to emulate. Perhaps "implement"?
jseldess
force-pushed
the
show-all-updates
branch
from
3eddf44 to
1a23e51
Compare
|
LGTM |
|
LGTM |
jseldess
force-pushed
the
show-all-updates
branch
from
1a23e51 to
b8a4d71
Compare
Simran-B
added a commit
to Simran-B/docs
that referenced
this pull request
Aug 21, 2025
* Add loading state * Documented missing states 'none' and 'fatal error' Additionally, reordered states based on occurance during a run and relevance for the user. * Review * Fix link * Update examples for 3.10 in feature/add-loading-state-to-list-of-pregel-states at 2022-08-11T15:39:29+02:00 * Fix 3-way merge mistakes Co-authored-by: Simran Spiller <simran@arangodb.com> Co-authored-by: ansoboleva <93702078+ansoboleva@users.noreply.github.com> Co-authored-by: arangodb-release-bot <anastasia.soboleva@arangodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
MAX_INDEX_KEYS,SEARCH_PATH, andSERVER_VERSIONvariables to theSHOW ALLstatement documentation. Fixes #933. Fixes #790.It also changes the Develop sidebar a bit:
SQL Syntaxto better house topics like constants, keywords, expressions, and the full grammar.@knz, the addition of
search_pathto theshow alldocs goes well with your PR on name resolution. I'll get that reviewed in the morning. If we merge that first, I can link to those docs from thesearch_pathdescription on theshow allpage.This change is