-
Notifications
You must be signed in to change notification settings - Fork 474
Update java "build an app" tutorial #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, in the language/driver/ORM matrix, it still says "Hibernate support coming soon" Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions. build-a-java-app-with-cockroachdb.md, line 43 at r1 (raw file):
This is macOS-specific. On Ubuntu Linux, it'd be build-a-java-app-with-cockroachdb.md, line 105 at r1 (raw file):
The part about build-a-java-app-with-cockroachdb.md, line 108 at r1 (raw file):
This code block should have some heading to identify it, like the filename ( build-a-java-app-with-cockroachdb.md, line 117 at r1 (raw file):
s/shoud/should/ Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions. build-a-java-app-with-cockroachdb.md, line 105 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
Cuong is correct, this isn't quite right. You can say something like "The Account class defines a model representing an account.". The part that instructs Hibernate to turn the model into a table is actually in the top of the file, where it says Comments from Reviewable |
Updated that matrix, @cuongdo. Thanks. Review status: 0 of 2 files reviewed at latest revision, 5 unresolved discussions. build-a-java-app-with-cockroachdb.md, line 43 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
Done. build-a-java-app-with-cockroachdb.md, line 105 at r1 (raw file): Previously, jordanlewis (Jordan Lewis) wrote…
Reworked with Jordan's help. build-a-java-app-with-cockroachdb.md, line 108 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
I need to research how to do this. Might have to do it after merging. build-a-java-app-with-cockroachdb.md, line 117 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
Done. Comments from Reviewable |
a654d39
to
1a4950f
Compare
Reviewed 2 of 2 files at r2. Comments from Reviewable |
…db#1100) * adjustements after dropping Hybrid name * review Co-authored-by: ansoboleva <93702078+ansoboleva@users.noreply.github.com>
This PR updates the java "build an app" tutorial to cover both the jdbc driver and the Hibernate ORM.
@jordanlewis, @cuongdo, not sure if the "Run the Java code" step is as clear as it should be. Please don't hold back.
This change is