Update node txn sample to pass results back from the transaction #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the node.js transaction sample code to perform a SELECT as part of the transaction and return the results through the txn wrapper. Addresses node component of issue cockroachdb#1606
|
This change is |
taywrobel
commented
Jun 22, 2017
| @@ -84,15 +84,20 @@ function transferFunds(client, from, to, amount, next) { | |||
| var acctBal = results.rows[0].balance; | |||
| if (acctBal >= amount) { | |||
| // Perform the transfer. | |||
| async.series([ | |||
| async.waterfall([ | |||
There was a problem hiding this comment.
Switched from series to waterfall here, since with waterfall only the last async step has it's results sent to the final async callback. Series returns the results of each function as separate callback parameters.
With series the outer function would need to have a signature along the lines of function (err, firstUpdateResults, secondUpdateResults, selectResults) { which I didn't think was as clear as this, where the transfer funds function returns just the updated funds.
jseldess
approved these changes
Jun 22, 2017
|
Also, @justinj tested your change, and everything works great. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the node.js transaction sample code to perform a SELECT as
part of the transaction and return the results through the txn
wrapper.
Addresses node component of issue #1606