Update versioning dropdown #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
- main nav was never given community dropdown on docs, so adding here - sidenav menu top property was changed to padding-top when versioning was adding, revert to top to fix
benesch
reviewed
Aug 4, 2017
js/customscripts.js
Outdated
| if (_viewport_width > 992) { | ||
| $('#version-switcher').show(); | ||
| } else { | ||
| $('#version-switcher').hide(); |
There was a problem hiding this comment.
Might as well use $versionSwitcher here.
|
Thanks, @deronjohnson! |
1 similar comment
|
TeamCity is failing on some external links to Digital Ocean. I'll merge this and resolve those links in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the versioning switch dropdown into the docs nav on mobile, and updates the style at all sizes.