Skip to content

Add missing pages and document SHOW BACKUP #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 29, 2017
Merged

Add missing pages and document SHOW BACKUP #1869

merged 7 commits into from
Aug 29, 2017

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 29, 2017 •
edited by jseldess
Loading

Docs-side fix for #1822.

Also fixes #1504.

@knz knz requested a review from jseldess August 29, 2017 14:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4133ed84adebc80d85d925500e8c42e05d719ee4/

jseldess
jseldess approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @knz. The content here LGTM. Do you mind if I take this over and add these statements to the sidenav and sql statement overview page?

@knz knz mentioned this pull request Aug 29, 2017
Merged
@knz
Copy link
Contributor Author

knz commented Aug 29, 2017

That would be great, thanks!

@jseldess
Copy link
Contributor

OK, I'll push some updates soon.

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/44d537e1ae7efe08f966c15e453e0ac226a91009/

@knz
Copy link
Contributor Author

knz commented Aug 29, 2017

:lgtm:

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dd9711cff67840dd6914e84160e159ed419b3993/

@jseldess jseldess changed the title Add missing pages. Add missing pages and document SHOW BACKUP Aug 29, 2017
@jseldess jseldess merged commit 8319b6e into cockroachdb:master Aug 29, 2017
@knz knz mentioned this pull request Aug 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jseldess jseldess jseldess approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: SHOW BACKUP
3 participants
@knz @cockroach-teamcity @jseldess