Stored computed columns support FKs, with limits #18792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed: |
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
spilchen
approved these changes
Aug 7, 2024
taroface
reviewed
Aug 7, 2024
| - Cannot be used to generate other computed columns. | ||
| - Behave like any other column, with the exception that they cannot be written to directly. | ||
| - Are mutually exclusive with [`DEFAULT`]({% link {{ page.version.version }}/default-value.md %}) and [`ON UPDATE`]({% link {{ page.version.version }}/create-table.md %}#on-update-expressions) expressions. | ||
| - Can be used in [`FOREIGN KEY`]({% link {{ page.version.version }}/foreign-key.md %}) constraints, but restricted to the following subset of supported options. The restriction to this subset is necessary because we cannot allow the computed column value to change. Prior to this change, stored computed columns could not be used in foreign key constraints at all. |
There was a problem hiding this comment.
Should there be a "new in 24.2" tag here? I think the last sentence should be cut because it reads like a release note and will likely confuse in subsequent versions.
Suggested change
| - Can be used in [`FOREIGN KEY`]({% link {{ page.version.version }}/foreign-key.md %}) constraints, but restricted to the following subset of supported options. The restriction to this subset is necessary because we cannot allow the computed column value to change. Prior to this change, stored computed columns could not be used in foreign key constraints at all. | |
| - Can be used in [`FOREIGN KEY`]({% link {{ page.version.version }}/foreign-key.md %}) constraints, but are restricted to the following subset of supported options. This restriction is necessary because we cannot allow the computed column value to change. |
There was a problem hiding this comment.
good points both
updated the text as you suggested
also added the "new in" thingy
PTAL!
taroface
approved these changes
Aug 8, 2024
rmloveland
deleted the
20240806-DOC-10491-foreign-keys-on-computed-columns
branch
mdlinville
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Stored computed columns support FKs, with limits Fixes DOC-10491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-10491