Skip to content

Conversation

rmloveland
Copy link
Contributor

Fixes EDUENG-112

This patch eliminates the deprecated Uglifier warnings and improves build performance without affecting functionality.

Fixes EDUENG-112

This patch eliminates the deprecated Uglifier warnings and improves
build performance without affecting functionality.
@rmloveland rmloveland requested a review from ebembi-crdb August 21, 2025 15:32
Copy link

github-actions bot commented Aug 21, 2025

Files changed:

  • src/current/_config_base.yml

Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 08c7030
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68ac7619fd2f79000862da33

Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 08c7030
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68ac76196b91e5000850a915

Copy link

netlify bot commented Aug 21, 2025

Netlify Preview

Name Link
🔨 Latest commit 08c7030
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68ac7619a96f0e0008ab226f
😎 Deploy Preview https://deploy-preview-20178--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@ebembi-crdb ebembi-crdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmloveland
Copy link
Contributor Author

@ebembi-crdb looks like cockroachdb-api-docs and cockroachdb-interactive-tutorials-docs are broken. Should I modify this PR to only change the value in src/current/_config_base.yml and leave the other things alone?

They were breaking the build for those targets, and I can't test them
locally.
@rmloveland rmloveland enabled auto-merge (squash) August 25, 2025 14:41
@rmloveland
Copy link
Contributor Author

I went ahead and backed out the changes to the API docs and tutorials since I have no way to test them locally and they were failing the build for some reason. Merging just the changes to the main docs site

@rmloveland rmloveland merged commit 1fd7f89 into main Aug 25, 2025
6 checks passed
@rmloveland rmloveland deleted the 20250821-EDUENG-112-disable-deprecated-harmony-warnings branch August 25, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants