-
Notifications
You must be signed in to change notification settings - Fork 472
Disable legacy 'harmony' option from uglifier_args #20178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable legacy 'harmony' option from uglifier_args #20178
Conversation
Fixes EDUENG-112 This patch eliminates the deprecated Uglifier warnings and improves build performance without affecting functionality.
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ebembi-crdb looks like |
They were breaking the build for those targets, and I can't test them locally.
I went ahead and backed out the changes to the API docs and tutorials since I have no way to test them locally and they were failing the build for some reason. Merging just the changes to the main docs site |
Fixes EDUENG-112
This patch eliminates the deprecated Uglifier warnings and improves build performance without affecting functionality.