DOC-14412 Product Change- PR #150364 - sql, settings, cli: Add sensitive, reportable columns to cluster_settings and update debug zip setting redaction logic #20371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct flag and example.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed: |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
kyle-a-wong
approved these changes
Sep 24, 2025
taroface
requested changes
Sep 26, 2025
There was a problem hiding this comment.
I think that the redaction behavior is unclear because the exceptions are scattered throughout the description. I provided a suggestion to group them together, but feel free to do what you think is best.
Also, the significance of "non-default values" is unclear to me - why do we need to call out that these are also redacted? Is it possible to clarify that in the table?
…Cluster settings redaction example.
|
@taroface Thank you for your clear-eyed suggestions! Please review the expanded description and example. |
taroface
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-14412 DOC-14566
In cockroach-debug-zip.md, added cluster settings redaction to --redact flag and example.
Rendered preview
--redactflag