Skip to content

Conversation

a-robinson
Copy link
Contributor

No description provided.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

@a-robinson
Copy link
Contributor Author

+@bdarnell to make sure the terminology around versions (e.g. v1.1 vs v1.1.0) is reasonable, since @Amruta-Ranade isn't sure and @jseldess is out right now.

@bdarnell
Copy link
Contributor

:lgtm:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

Copy link
Contributor Author

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly simplified the first sentence at @Amruta-Ranade's offline request.

@cockroach-teamcity
Copy link
Member

Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We also call this out at the end of the "Finalize the upgrade" step.

@a-robinson a-robinson merged commit 575ab66 into cockroachdb:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants