Update secure Kubernetes instructions with RBAC support #2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables them to work on more clusters (including non-GKE clusters) by default.
|
This change is |
jseldess
commented
Dec 13, 2017
| @@ -26,6 +26,31 @@ Choose whether you want to orchestrate CockroachDB with Kubernetes using the hos | |||
|
|
|||
| The process can take a few minutes, so don't move on to the next step until you see a `Creating cluster cockroachdb...done` message and details about your cluster. | |||
|
|
|||
| {% if page.secure == true %} | |||
There was a problem hiding this comment.
@a-robinson, I added this filter to make sure these RBAC steps don't get pulled into the insecure tutorials.
There was a problem hiding this comment.
Also made sense to move this content into this include file. But it's only showing up for Hosted GKE. Is RBAC relevant for the other methods as well?
There was a problem hiding this comment.
RBAC in general is relevant for other methods. These two steps below are a workaround for GKE limitations and aren't relevant for any other environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables them to work on more clusters (including non-GKE clusters)
by default.
This PR replaces #2271.