Skip to content

Conversation

Amruta-Ranade
Copy link
Contributor

@jseldess @awoods187
This is the first draft of the SQL Standard compatibility matrix - just making sure I am on the right track.

I was considering breaking up the table into three tables: supported, unsupported, and partially-supported features. Thoughts?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

@awoods187
Copy link
Contributor

Great first step! Can you remove the "??" ? Let's go ahead and label those as "No." Also, is it possible to filter this list? Could someone just look at what we do or don't support?

Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first step!

@awoods187, I can look into adding the ability to filter in a follow-up PR.

@Amruta-Ranade, @awoods187, do we want to add this for 1.1 docs as well, or just for 2.0?

@awoods187
Copy link
Contributor

Let's go ahead and mark it for 1.1

Makes sense re filter follow up

@cockroach-teamcity
Copy link
Member

@bdarnell
Copy link
Contributor

We shouldn't just copy the same file from 2.0 to 1.1 - some of those checkboxes won't be the same. Unless someone wants to go through and make sure that all the differences are noted I think it would be better to start this page in 2.0 and update it going forward.


## Overview

This page lists which SQL standard features are supported, partially-supported, and unsupported by CockroachDB.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest simplifying this page by removing the toc and Overview headingh and starting the page with this:

This page outlines to what extent CockroachDB conforms to the current SQL standard.

  • Feature ID ...
  • Description ...
  • CockroachDB Support ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies also the 1.1 version of the page.

@jseldess
Copy link
Contributor

Makes sense to me, @bdarnell. @Amruta-Ranade, let's just remove this content from 1.1 docs. Sorry to cause confusion here.

@cockroach-teamcity
Copy link
Member

@cockroach-teamcity
Copy link
Member

@jseldess jseldess merged commit 0436aa2 into master Jan 30, 2018
@jseldess jseldess deleted the postgres_compatibility branch January 30, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants