-
Notifications
You must be signed in to change notification settings - Fork 474
Doc updates for planned maintenance events #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7a042fc
to
af982d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
af982d5
to
870d0e9
Compare
TFTR, @dianasaur323! |
Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending. v2.0/upgrade-cockroach-version.md, line 34 at r5 (raw file):
Why would you expect this much downtime during a rolling upgrade? You should easily be able to complete your cockroach upgrade within the default 5m window (as long as you're automating things instead of typing them by hand during the upgrade). In my experience the only thing that might take long enough to warrant an increase in server.time_until_store_dead is a kernel upgrade. Comments from Reviewable |
870d0e9
to
90efa5a
Compare
v2.0/upgrade-cockroach-version.md, line 34 at r5 (raw file): Previously, bdarnell (Ben Darnell) wrote…
Downgraded this to a note that states 5 min should be more than enough. Calls out the setting just in case. Is that ok, @bdarnell? Comments from Reviewable |
Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. v2.0/upgrade-cockroach-version.md, line 34 at r5 (raw file): Previously, jseldess wrote…
I'd probably leave it out completely, but I guess since we're writing these instructions as if you're running commands by hand instead of automating it it may be worth leaving in a mention. Comments from Reviewable |
v2.0/upgrade-cockroach-version.md, line 34 at r5 (raw file): At the beginning of the "Perform the rolling upgrade" section, we have a tip:
But I'd like to get more information from you about how this page could be more focused on automation. Seems to me that manual steps are necessary given that users will use differing tools. But I'd love to create and link to an example script or config for a specific system as well. Comments from Reviewable |
- Add an operational FAQ - Add note to rolling upgrades doc - Minor improvements to cockroach quit doc
d762d8d
to
c2b4566
Compare
Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. v2.0/upgrade-cockroach-version.md, line 34 at r5 (raw file): Previously, jseldess (Jesse Seldess) wrote…
My view is that we have to walk through the manual process here so that people will understand what they have to write in their scripts. Over time we can develop a library of scripts/configs (like we have for kubernetes, etc), and those automated versions will displace these manual steps. Comments from Reviewable |
Fixes #2038