Add the referential_constraints view to information schema #2637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
+cc @knz |
knz
reviewed
Mar 8, 2018
There was a problem hiding this comment.
Thanks for tackling this.
Mostly good, except for a bug in views.
paging @nvanbenschoten for additional control
v2.0/information-schema.md
Outdated
| @@ -168,8 +189,8 @@ The `views` view identifies [views](views.html) in the cluster. | |||
|
|
|||
| Column | Description | |||
| -------|----------- | |||
| `TABLE_CATALOG` | Always equal to `def` (CockroachDB does not support the notion of catalogs). | |||
| `TABLE_SCHEMA` | Name of the database that the view reads from. | |||
| `TABLE_CATALOG` | Name of the database that the view reads from. | |||
There was a problem hiding this comment.
Both the original doc text and the new one are incorrect. the table_xxx columns in this table refer to the view itself, not the table(s) being read from. A view can read from multiple tables.
knz
approved these changes
Mar 8, 2018
|
Could somebody tell me what the CI failure here means / what I should do to correct it? |
jseldess
approved these changes
Mar 8, 2018
Update all information schema tables to match implementations, including updating the meanings of `_CATALOG` and `_SCHEMA` columns. From my review, other incomplete items in information_schema that require fixes: - CHARACTER_SET_* and GENERATION_EXPRESSION in `columns` table. - administrable_role_authorizations - applicable_roles - column_privileges - enabled_roles - role_table_grants - sequences - `statistics` table needs `IMPLICIT` defined. See cockroachdb#2017 Fixes cockroachdb#2508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all information schema tables to match implementations, including
updating the meanings of
_CATALOGand_SCHEMAcolumns.From my review, other incomplete items in information_schema that
require fixes:
columnstable.statisticstable needsIMPLICITdefined.See #2017
Fixes #2508