Attempt to clarify the node status command's updated_at field #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jseldess
approved these changes
Mar 8, 2018
There was a problem hiding this comment.
LGTM, @a-robinson!
I don't think we have a good place to point to describing what it means for a node to be "live", unfortunately. So this seems good enough for now. Thank you!
|
@a-robinson, you just need to update your copy of master, rebase, and push again to pass TC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2249
Also add the appropriate descriptions/field names for the v1.0 docs while I'm here.
I'm not sure this is really the best explanation, but I'm also skeptical that it's worth going into great detail here since it could easily confuse people in the common case that there's nothing weird about the values. It'd probably help if we had a good definition of what it means to be "live" that we could link to from here. Do we?