Add auto_trace & remove SHOW TRACE #3508
Conversation
|
This change is |
lnhsingh
changed the title
|
@knz, in the old docs for |
There was a problem hiding this comment.
results option.
Reviewed 1 of 1 files at r1, 3 of 4 files at r2, 3 of 3 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
v2.1/set-vars.md, line 248 at r3 (raw file):
`on` | Same as `cluster`. `kv` | Same as `cluster` except that "kv messages" are collected instead of regular trace messages. See [`SHOW TRACE FOR SESSION`](show-trace-for-session.html). `local` | Trace recording is enabled; only trace messages issued by the local node are collected.
there is a new option results too.
There was a problem hiding this comment.
Reviewable status:
v2.1/show-trace-for-session.md, line 140 at r3 (raw file):
~~~ <!-- ### Trace conflicting transactions
@knz, in the old docs for SHOW TRACE, we have an example that shows how to trace conflicting transactions. Can you do this with SHOW TRACE FOR SESSION? If you can, I can't figure out how to do it.
There was a problem hiding this comment.
Reviewable status:
v2.1/set-vars.md, line 248 at r3 (raw file):
Previously, knz (kena) wrote…
there is a new option
resultstoo.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, 2 of 2 files at r5.
Reviewable status:
v2.1/show-trace-for-session.md, line 140 at r3 (raw file):
Previously, lhirata wrote…
@knz, in the old docs for SHOW TRACE, we have an example that shows how to trace conflicting transactions. Can you do this with SHOW TRACE FOR SESSION? If you can, I can't figure out how to do it.
Yes I'm sure you can but I don't recall the steps exactly either. Andrei, Bram, Nathan would know.
v2.1/set-vars.md
Outdated
| `local` | Trace recording is enabled; only trace messages issued by the local node are collected. | ||
| `results` | Result rows and row counts are copied to the session trace. This must be specified explicitly when printing the results produced by a query in the trace is needed.<br><br>Example: `SET tracing = kv, results;` |
There was a problem hiding this comment.
I'm not sure I understand this sentence. Do you mean something like "this must be specified in order for the output of the query to be printed to the session trace" (or?)
| `client_min_messages` | Ignored; recognized for compatibility with PostgreSQL clients. Only posible value is "`on`". | N/A | No | ||
| `extra_float_digits` | Ignored; recognized for compatibility with PostgreSQL clients. | N/A | No | ||
| `standard_conforming_strings` | Ignored; recognized for compatibility with PostgreSQL clients. | N/A | No | ||
| `application_name` | The current application name for statistics collection. | Empty string | Yes |
There was a problem hiding this comment.
Is this block all whitespace changes? (I think yes but wanted to confirm.)
There was a problem hiding this comment.
Reviewable status:
v2.1/set-vars.md, line 39 at r5 (raw file):
Previously, rmloveland (Rich Loveland) wrote…
Is this block all whitespace changes? (I think yes but wanted to confirm.)
Yep
v2.1/set-vars.md, line 249 at r5 (raw file):
Previously, rmloveland (Rich Loveland) wrote…
I'm not sure I understand this sentence. Do you mean something like "this must be specified in order for the output of the query to be printed to the session trace" (or?)
Updated. Thanks!
New SQL shell option called
auto_trace, which shows tracing for every subsequent statement. RemoveSHOW TRACEin v2.1 docs.Closes #3475 and #3452.