Skip to content

Document the cockroach demo command #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2018
Merged

Document the cockroach demo command #3509

merged 1 commit into from
Aug 8, 2018

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented Aug 6, 2018 •
edited
Loading

Fixes #3096.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/900a1a391cbe409add68b2c92b1fc758254e0c43/

@jseldess jseldess changed the title [WIP] Document the cockroach demo command Document the cockroach demo command Aug 7, 2018
@jseldess jseldess requested review from jordanlewis and knz August 7, 2018 20:04
@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cd2b72e773e5692d3f44e0d58b973fed5131e3b7/

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e1111e4d4dc80f25e0fa0ce188f37d3172718c27/

@jordanlewis
Copy link
Member

LGTM - thank you!

knz
knz approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@jseldess
Copy link
Contributor Author

jseldess commented Aug 8, 2018

TFTRs, @knz and @jordanlewis. I'm just waiting to land #3499 before merging this, since the links here depend on that PR.

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/1e9ea083667d8d9c289f94d3bc3ec8883b8c03aa/

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/64cf77e267ed3aef300927b61c9751e80c92dc07/

@jseldess jseldess merged commit bd8bf97 into master Aug 8, 2018
@jseldess jseldess deleted the cockroach-demo branch August 8, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanlewis jordanlewis Awaiting requested review from jordanlewis

1 more reviewer

@knz knz knz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jseldess @cockroach-teamcity @jordanlewis @knz