Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexidecimal string and numeric literals #392

Merged
merged 2 commits into from Jun 16, 2016
Merged

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented Jun 16, 2016

Adding hexadecimal string literal format to STRING type docs and hexadecimal numeric literal format to INT type docs.

Fixes #377


This change is Reviewable

@jordanlewis
Copy link
Member

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.


int.md, line 27 [r1] (raw file):

### Unicode Numeric Literal

When inserting a Unicode numeric literal into an `INT` column, format the value as `12345`.

I don't think you should call these unicode numeric literals. They're just numeric literals.


int.md, line 30 [r1] (raw file):

### Hexadecimal Numeric Literal

I think this makes sense.


string.md, line 47 [r1] (raw file):

### Hexadecimal String Literal

When inserting a hexadecimal string literal into a `STRING` column, use `x` or `X` followed by hexadecimal digits in single quotes. For example, `x'636174'` or `X'636174'` correspond to the Unicode string literal `'cat'`.

This makes sense.


Comments from Reviewable

@jseldess
Copy link
Contributor Author

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.


int.md, line 27 [r1] (raw file):

Previously, jordanlewis (Jordan Lewis) wrote…

I don't think you should call these unicode numeric literals. They're just numeric literals.

Done.

Comments from Reviewable

@jseldess jseldess merged commit 37d782d into gh-pages Jun 16, 2016
@jseldess jseldess deleted the hexadecimal-literals branch June 16, 2016 18:17
@jordanlewis
Copy link
Member

:lgtm: Thanks! I like the new wording about formats.


Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants