Skip to content

Document BIT/VARBIT. #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

Document BIT/VARBIT. #4454

merged 1 commit into from
Mar 11, 2019

Conversation

knz
Copy link
Contributor

@knz knz commented Mar 2, 2019

Fixes #4070.
First commit from #4452.

@rmloveland feel free to take this over.

@knz knz requested review from rmloveland and jseldess March 2, 2019 21:24
@knz knz added the in progress label Mar 2, 2019
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2965c162c0d945dceebbb0a7b324f2e24dd3f4d0/

@rmloveland
Copy link
Contributor

Taking over - thanks Raphael!

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9fb31f423fc770ff4b8b6ad8d70c1580b9fbe05a/

@jseldess jseldess removed their request for review March 4, 2019 20:26
@jseldess
Copy link
Contributor

jseldess commented Mar 4, 2019

@rmloveland, please re-assign me when you're ready for review.

@rmloveland rmloveland requested review from jseldess and removed request for rmloveland March 4, 2019 20:34
jseldess
jseldess approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few nits.

@rmloveland
Copy link
Contributor

Thanks for the review Jesse! I don't see any comments about the nits you found though. (Maybe I'm missing them somehow?)

@knz
Copy link
Contributor Author

knz commented Mar 7, 2019

you'll need to rebase since the other pr was merged underneath

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/65a3b135e1d21c2dff27591b5ce80eddebc4e206/

@rmloveland
Copy link
Contributor

Thanks Raphael - rebased and fixed conflicts but still not seeing comments. Oh well, gotta move on to some other higher-prio tasks. Gonna merge since LGTM'd.

@rmloveland rmloveland merged commit a3e67c7 into cockroachdb:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jseldess jseldess jseldess approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knz @cockroach-teamcity @rmloveland @jseldess