Skip to content

Conversation

jseldess
Copy link
Contributor

Fixes #4433.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jseldess
Copy link
Contributor Author

@bdarnell, is this sufficient, or do we need to explicitly call this out in the install pages and/or the deployment tutorials?

@jseldess jseldess changed the title Documentat tzdata dependency Document tzdata dependency Mar 22, 2019
@jseldess jseldess force-pushed the tzdata-dependency branch from fa25f74 to 698596d Compare March 22, 2019 03:28
@cockroach-teamcity
Copy link
Member

@cockroach-teamcity
Copy link
Member

Copy link
Contributor

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the tzdata package is usually installed by default (and is nearly always present on development machines), it's probably fine to only mention it here. But technically it's an install-time requirement at the same level as glibc and libncurses.


## Time zone data

Certain features of CockroachDB require the [`tzdata`](https://www.iana.org/time-zones) package (sometimes called `tz` or `zoneinfo`), for example, to support using place names as time zone identifiers. Therefore, ensure that this package is installed and kept up-to-date on all VMs where CockroachDB nodes are running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"machines", not VMs - we don't know or care whether they're virtualized.

This does not apply to docker-based deployments. The tzdata package is included in the docker image and is update with each patch release of cockroachdb.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I'll work on one more commit adding the tzdata error to the common errors page.

@jseldess jseldess force-pushed the tzdata-dependency branch from 698596d to ecdd2b6 Compare March 22, 2019 19:20
@cockroach-teamcity
Copy link
Member

@jseldess jseldess force-pushed the tzdata-dependency branch from ecdd2b6 to b8ff369 Compare March 22, 2019 19:38
@cockroach-teamcity
Copy link
Member

@jseldess
Copy link
Contributor Author

@bdarnell, PTAL again.

I'm not sure why the build is failing. The anchors it's complaining about are perfectly fine.

@cockroach-teamcity
Copy link
Member

@cockroach-teamcity
Copy link
Member

@jseldess jseldess force-pushed the tzdata-dependency branch from e683b9b to 5a37e69 Compare March 24, 2019 22:28
@cockroach-teamcity
Copy link
Member

@jseldess jseldess merged commit abc3650 into master Mar 24, 2019
@jseldess jseldess deleted the tzdata-dependency branch March 24, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants