Skip to content

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Apr 3, 2019

This "Install CockroachDB on Windows" page has a warning box but the
bolded text is "Native CockroachDB on Windows requires Windows 8 or
higher" and the experimental status is a bit hidden in the rest of the
box. This binary is almost entirely untested, so I'd suggest we swap the
bolded text to be about the experimental status of the binary.
Otherwise, I worry that users may form a bad initial impression of our
performance/stability/maturity (and perhaps don't bother contacting us
as a result).

This "Install CockroachDB on Windows" page has a warning box but the
bolded text is "Native CockroachDB on Windows requires Windows 8 or
higher" and the experimental status is a bit hidden in the rest of the
box. This binary is almost entirely untested, so I'd suggest we swap the
bolded text to be about the experimental status of the binary.
Otherwise, I worry that users may form a bad initial impression of our
performance/stability/maturity (and perhaps don't bother contacting us
as a result).
@danhhz danhhz requested a review from jseldess April 3, 2019 19:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz added the in progress label Apr 3, 2019
@danhhz
Copy link
Contributor Author

danhhz commented Apr 3, 2019

cc @bdarnell in case you have any thoughts about the phrasing of the part about testing. I tried strengthening the language here from "has not been extensively tested by Cockroach Labs" to "is largely untested by Cockroach Labs".

@jseldess
Copy link
Contributor

jseldess commented Apr 3, 2019

Thanks, @danhhz. I'm ok with this, but note that there are some other issues around windows that we have yet to resolve. For example, this issue suggest that we should remove docker and kubernetes options for windows and encourage running in a linux vm: #3184 (comment).

@rolandcrosby is helping with this, so he may have some opinions, too.

@danhhz
Copy link
Contributor Author

danhhz commented Apr 3, 2019

Gotcha. I'm not too tied to this. Just found myself filing an issue about it and realized that it was literally less work to PR than to finish writing up the issue. Happy to merge as an interim solution if that makes sense or throw it away if it doesn't.

Copy link

@rolandcrosby rolandcrosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to do more with the recommendations further down on the page like Jesse mentions, but in the meantime I think it's good to be more forceful about the warning.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jseldess)

@jseldess
Copy link
Contributor

jseldess commented Apr 3, 2019

I'll merge for you, @danhhz. Thank you!

@jseldess jseldess merged commit ac86ebd into master Apr 3, 2019
@jseldess jseldess deleted the danhhz_windows branch April 3, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants