Update k8s tutorials #4805
Update k8s tutorials #4805
Conversation
|
This change is |
|
@DuskEagle, sorry for including so many unrelated formatting changes in this PR. The files to look at for the
|
jseldess
force-pushed
the
kubernetes-helm-updates
branch
from
0937e8e to
bb86a3f
Compare
There was a problem hiding this comment.
Reviewed 7 of 14 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DuskEagle and @jseldess)
_includes/v19.1/orchestration/kubernetes-remove-nodes-insecure.md, line 37 at r1 (raw file):
cockroachdb/cockroach:{{page.release_info.version}}
Maybe change to cockroachdb/cockroach:{{page.release_info.version}}?
_includes/v19.1/orchestration/kubernetes-scale-cluster.md, line 24 at r1 (raw file):
has been upgraded
I don't see this section showing up on the test website even when looking at the helm section
_includes/v19.1/orchestration/kubernetes-upgrade-cluster.md, line 143 at r1 (raw file):
my-release-cockroachdb-0 1/1 Running 0 2m my-release-cockroachdb-1 1/1 Running 0 3m my-release-cockroachdb-1 1/1 Running 0 3m
cockroachdb-2
_includes/v19.1/orchestration/start-cockroachdb-helm-secure.md, line 154 at r1 (raw file):
~~~ 7. Confirm that cluster initialization has completed successfully, with the pods for nodes showing `1/1` under `READY` and the pod for initialization showing `COMPLETED` under `STATUS`:
nodes is a little bit ambiguous here, since Kubernetes also has a concept of nodes. I might say the pods for cockroachdb.
- Use helm upgrade for adding and removing nodes and cluster upgrades - Correct downgrade option for 19.1 k8s upgrade - Wrap commands to be more visible Fixes #4689.
jseldess
force-pushed
the
kubernetes-helm-updates
branch
from
bb86a3f to
aab4d2f
Compare
There was a problem hiding this comment.
TFTR, @DuskEagle. Let me know if there's anything else.
Reviewable status:
_includes/v19.1/orchestration/kubernetes-remove-nodes-insecure.md, line 37 at r1 (raw file):
Previously, DuskEagle (Joel Kenny) wrote…
cockroachdb/cockroach:{{page.release_info.version}}Maybe change to
cockroachdb/cockroach:{{page.release_info.version}}?
Done.
_includes/v19.1/orchestration/kubernetes-scale-cluster.md, line 24 at r1 (raw file):
Previously, DuskEagle (Joel Kenny) wrote…
has been upgradedI don't see this section showing up on the test website even when looking at the helm section
Hmm, it shows up for me...
_includes/v19.1/orchestration/kubernetes-upgrade-cluster.md, line 143 at r1 (raw file):
Previously, DuskEagle (Joel Kenny) wrote…
cockroachdb-2
Done.
_includes/v19.1/orchestration/start-cockroachdb-helm-secure.md, line 154 at r1 (raw file):
Previously, DuskEagle (Joel Kenny) wrote…
nodesis a little bit ambiguous here, since Kubernetes also has a concept ofnodes. I might saythe pods for cockroachdb.
Done.
There was a problem hiding this comment.
Reviewed 6 of 14 files at r1, 3 of 3 files at r2.
Reviewable status:
a discussion (no related file):
|
@Amruta-Ranade, ready for your review. |
Fixes #4689.