Skip to content

Edit BACKUP/RESTORE system.users #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

Edit BACKUP/RESTORE system.users #5072

merged 1 commit into from
Jul 18, 2019

Conversation

lnhsingh
Copy link
Contributor

@lnhsingh lnhsingh commented Jul 18, 2019 •
edited
Loading

Closes #5002

@lnhsingh lnhsingh requested review from dt and rkruze July 18, 2019 17:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/873e2729a5563b1bff824fa355b35f60cf0b183c/

Edited pages:

rkruze
rkruze reviewed Jul 18, 2019
View reviewed changes
Copy link
Contributor

@rkruze rkruze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt and @rkruze)

@lnhsingh lnhsingh requested a review from Amruta-Ranade July 18, 2019 20:32
@lnhsingh lnhsingh merged commit 5bb0dfa into master Jul 18, 2019
@lnhsingh lnhsingh deleted the system-users branch July 18, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt dt Awaiting requested review from dt

2 more reviewers

@rkruze rkruze rkruze left review comments

@Amruta-Ranade Amruta-Ranade Amruta-Ranade approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

system.users is not included with backup
4 participants
@lnhsingh @cockroach-teamcity @rkruze @Amruta-Ranade