Skip to content

Conversation

ericharmeling
Copy link
Contributor

Fixes #4443.

Wording clarified on merge joins to reflect nuance of join choice algorithm.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a clarity / copy-editing perspective.

@ericharmeling
Copy link
Contributor Author

Merging this. @awoods187, let me know if this isn't sufficient to resolve #4443.

@ericharmeling ericharmeling merged commit 500ffd6 into master Sep 24, 2019
@awoods187
Copy link
Contributor

lgtm

@ericharmeling ericharmeling deleted the join-choice branch August 24, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nuance to join choice algorithm
4 participants