-
Notifications
You must be signed in to change notification settings - Fork 474
adding SQL feature support matrix #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5d839fb
to
96c7abd
Compare
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. sql-feature-support.md, line 60 [r1] (raw file):
Given our current implementation, we should mark these with a footnote instead of a full "check". The footnote can say that these operations are supported only for small data sets. @knz what do you think? Comments from Reviewable |
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. sql-feature-support.md, line 60 [r1] (raw file):
|
96c7abd
to
2a26ca8
Compare
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. sql-feature-support.md, line 60 [r1] (raw file):
|
2a26ca8
to
40c8986
Compare
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
40c8986
to
5e0f0be
Compare
Excellent work, @sploiselle! LGTM. @nvanbenschoten, should introspection be added? If so, can you suggest an approach? Reviewed 2 of 2 files at r1. sql-feature-support.md, line 7 [r1] (raw file):
Let's continue this priority until the end of time: "...easy to use is a top priority for us..." sql-feature-support.md, line 11 [r1] (raw file):
nit: Would you mind using Comments from Reviewable |
5e0f0be
to
2cfbafe
Compare
@jseldess We could add a section for supported methods of introspection, but I foresee a page/section like https://www.postgresql.org/docs/9.5/static/information-schema.html being more immediately useful. Each subsection would provide a brief overview of a supported introspection table, along with it's schema. |
Thanks, @nvanbenschoten. Noted. |
This change is