-
Notifications
You must be signed in to change notification settings - Fork 473
features-on-develop-branch #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HTML version here: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0e410756c1dd4fe6c4253ede1fcf12e48be17313/ In particular, see: |
The build from source page doesn't say how to get the latest features we link to - one would need to do Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
@RaduBerinde, if you're doing this for the first time, |
Ah, I didn't realize Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. install-cockroachdb.md, line 208 [r1] (raw file):
Let's mention the develop branch here - maybe "this step builds a binary from the Comments from Reviewable |
This is great. Really impressed you put together so quickly! Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
LGTM, although I'd prefer the build-from-source instructions to default to the latest beta tag and present the Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
bccebc5
to
0a23176
Compare
@RaduBerinde, I made the reference to Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. install-cockroachdb.md, line 208 [r1] (raw file):
|
Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Thanks, all. I'll wait until we've documented a new feature on |
0a23176
to
8062548
Compare
8062548
to
0e41075
Compare
This PR covers how to get access to features on
develop
but not yet included in any official beta binary.install-cockroachdb.md
: Updated the build from source install instructions to mention building from code on thedevelop
branch._includes/develop-paragraph.md
and_includes/develop-callout.html
: Added reusable disclaimers to be used in docs for any feature only ondevelop
.develop-branch.md
: Added a page where we can list features available only on thedevelop
branch. Ideally, we'll link to the docs for the feature and list the date on which the feature was merged.@spencerkimball, @petermattis, @bdarnell, PTAL. Ben mentioned in chat that his preference would be to leave the install docs focused on the latest beta version and use
contributing.md
to focus ondevelop
. At that point, these changes were pretty much done, so I've decided to discuss here. Thoughts?Fixes #548
This change is