Add quit step to Manual Deployment docs

[jseldess]

Add step for stopping nodes.

Fixes #614

---

This change is

[mberhault]

I assume you checked that calling quit with user root works?

[sploiselle]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

manual-deployment.md, line 241 [r1] (raw file):

--key=root.key
should this be --key=node1.key? and the following two node2.key and node3.key respectively?

---

Comments from Reviewable

[mberhault]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

manual-deployment.md, line 241 [r1] (raw file):

Previously, sploiselle (Sean Loiselle) wrote…

--key=root.key
should this be --key=node1.key? and the following two node2.key and node3.key respectively?

it would be those keys if we were using the node certificate, but we definitely want it to work as the `root` user

---

Comments from Reviewable

[sploiselle]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

manual-deployment.md, line 241 [r1] (raw file):

Previously, mberhault (marc) wrote…

it would be those keys if we were using the node certificate, but we definitely want it to work as the root user

But the second and third nodes are quit using `node1.key` even though they wouldn't have that file stored on them? Or should all of them use `root.key`?

---

Comments from Reviewable

[jseldess]

manual-deployment.md, line 241 [r1] (raw file):

Previously, sploiselle (Sean Loiselle) wrote…

But the second and third nodes are quit using node1.key even though they wouldn't have that file stored on them? Or should all of them use root.key?

That's a mistake, @sploiselle. I'll fix that now.

---

Comments from Reviewable

[jseldess]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

manual-deployment.md, line 241 [r1] (raw file):

Previously, jseldess wrote…

That's a mistake, @sploiselle. I'll fix that now.

@mberhault, `quit` works with the cert and key for the `root` user on a local secure cluster. But I haven't tested this on GCE. Would it be any different?

@sploiselle, let me know if/how you'd suggest clarifying this step. For example, should add alternate commands if you are quitting from one of the node machines?

---

Comments from Reviewable

[mberhault]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

manual-deployment.md, line 241 [r1] (raw file):

Previously, jseldess wrote…

@mberhault, quit works with the cert and key for the root user on a local secure cluster. But I haven't tested this on GCE. Would it be any different?

@sploiselle, let me know if/how you'd suggest clarifying this step. For example, should add alternate commands if you are quitting from one of the node machines?

quitting the node on the local machine could be done with the node cert/key, but I'm not sure I would recommend it. It's easier to just send a signal to the process.

---

Comments from Reviewable

[mberhault]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

manual-deployment.md, line 241 [r1] (raw file):

Previously, mberhault (marc) wrote…

quitting the node on the local machine could be done with the node cert/key, but I'm not sure I would recommend it. It's easier to just send a signal to the process.

it should work just fine on GCE. as long at the root cert/key can be used to talk to the cluster as an application, it should work just fine for `cockroach quit`

---

Comments from Reviewable

[jseldess]

manual-deployment.md, line 241 [r1] (raw file):

Previously, mberhault (marc) wrote…

it should work just fine on GCE. as long at the root cert/key can be used to talk to the cluster as an application, it should work just fine for cockroach quit

OK, given that, am I good to merge now?

---

Comments from Reviewable