Improved vectorized support docs #6327
Conversation
|
This change is |
There was a problem hiding this comment.
Thanks for the update! A few comments from me.
Reviewed 24 of 24 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling)
v19.2/data-types.md, line 18 at r1 (raw file):
[`BYTES`](bytes.html) | A string of binary characters. | `b'\141\061\142\062\143\063'` | Supported [`COLLATE`](collate.html) | The `COLLATE` feature lets you sort [`STRING`](string.html) values according to language- and country-specific rules, known as collations. | `'a1b2c3' COLLATE en` | Not supported [`DATE`](date.html) | A date. | `DATE '2016-01-25'` | Not supported
DATE type is supported.
v19.2/data-types.md, line 19 at r1 (raw file):
[`COLLATE`](collate.html) | The `COLLATE` feature lets you sort [`STRING`](string.html) values according to language- and country-specific rules, known as collations. | `'a1b2c3' COLLATE en` | Not supported [`DATE`](date.html) | A date. | `DATE '2016-01-25'` | Not supported [`DECIMAL`](decimal.html) | An exact, fixed-point number. | `1.2345` | Not supported
DECIMAL is partially supported (we do not support the case when DECIMALs need to be sent over the network - i.e. we don't have serialization yet).
v19.2/data-types.md, line 28 at r1 (raw file):
[`STRING`](string.html) | A string of Unicode characters. | `'a1b2c3'` | Supported [`TIME`](time.html) | A time of day in UTC. | `TIME '01:23:45.123456'` | Not supported [`TIMESTAMP`<br>`TIMESTAMPTZ`](timestamp.html) | A date and time pairing in UTC. | `TIMESTAMP '2016-01-25 10:10:10'`<br>`TIMESTAMPTZ '2016-01-25 10:10:10-05:00'` | Supported
In 19.2 only Timestamp is supported (not TimestampTZ) (since 19.2.1, same as UUID).
v20.1/data-types.md, line 19 at r1 (raw file):
[`COLLATE`](collate.html) | The `COLLATE` feature lets you sort [`STRING`](string.html) values according to language- and country-specific rules, known as collations. | `'a1b2c3' COLLATE en` | Not supported [`DATE`](date.html) | A date. | `DATE '2016-01-25'` | Not supported [`DECIMAL`](decimal.html) | An exact, fixed-point number. | `1.2345` | Not supported
Same partial support at the moment (although this should be fully supported in the next alpha).
Added note to page for each data type not supported by vectorized execution
ericharmeling
force-pushed
the
vec-type-table
branch
from
769ac27 to
8faed71
Compare
There was a problem hiding this comment.
TFTR @yuzefovich ! Please see my comments and the latest commit, which addresses your review comments.
Reviewable status:
v19.2/data-types.md, line 18 at r1 (raw file):
Previously, yuzefovich wrote…
DATEtype is supported.
Done.
v19.2/data-types.md, line 19 at r1 (raw file):
Previously, yuzefovich wrote…
DECIMALis partially supported (we do not support the case when DECIMALs need to be sent over the network - i.e. we don't have serialization yet).
OK please review the latest commit on this.
v19.2/data-types.md, line 28 at r1 (raw file):
OK.
(since 19.2.1, same as UUID)
I'm a little confused by this. It looks like UUID is supported in 19.2: cockroachdb/cockroach#42414
Unless you are saying that 19.2.0 does not support UUID, but 19.2.1 does. In that case, we only document the latest version of a particular release (e.g. 19.2 docs should be correct for the latest 19.2.x, and not for 19.2.x versions prior to the latest).
v20.1/data-types.md, line 19 at r1 (raw file):
DECIMALs need to be sent over the network - i.e. we don't have serialization yet
Is this no longer the case as of yesterday? cockroachdb/cockroach#43311
Will this change be backported to 19.2 as well?
There was a problem hiding this comment.
Reviewed 9 of 9 files at r2.
Reviewable status:
v19.2/data-types.md, line 28 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
OK.
(since 19.2.1, same as UUID)
I'm a little confused by this. It looks like
UUIDis supported in 19.2: cockroachdb/cockroach#42414Unless you are saying that 19.2.0 does not support
UUID, but 19.2.1 does. In that case, we only document the latest version of a particular release (e.g. 19.2 docs should be correct for the latest 19.2.x, and not for 19.2.x versions prior to the latest).
Yeah, that's what I meant - the support for both Timestamp and UUID was added in 19.2.1 (those are not supported in 19.2.0). I see the point about the latest minor release, my remark then indeed is quite confusing :)
v20.1/data-types.md, line 19 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
DECIMALs need to be sent over the network - i.e. we don't have serialization yet
Is this no longer the case as of yesterday? cockroachdb/cockroach#43311
Will this change be backported to 19.2 as well?
Yes, as of yesterday for 20.1.
We do not plan to backport that change to 19.2 (to the best of my knowledge).
Fixes #5947.