AWS manual deploy #640
Merged
AWS manual deploy #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ~~~ shell | ||
| # Get the latest CockroachDB tarball. | ||
| $ wget https://binaries.cockroachdb.com/cockroach-{{site.data.strings.version}}.linux-amd64.tgz |
There was a problem hiding this comment.
should we be using latest for the binaries now that we have it?
|
LGTM |
|
@jseldess Take a look at this one for me? Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. deploy-cockroachdb-on-aws.md, line 86 at r1 (raw file):
|
|
I'm still not set up on AWS, so I didn't run through the steps myself, but the content Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy CockroachDB on AWS.
@mberhault – Could I get you to review for me?
This change is