-
Notifications
You must be signed in to change notification settings - Fork 473
Edit CDC examples to show more than one table in a changefeed #6511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b793f6f
to
1be18c6
Compare
cc @mwang1026 |
Closes #6109 Add multi-table changefeed examples
531cacf
to
6bfed07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @danhhz, @lnhsingh, and @piyush-singh)
v19.2/change-data-capture.md, line 428 at r1 (raw file):
{"after": {"id": 1, "name": "Petee H"}} {"after": {"id": 2, "name": "Carl"}} {"after": {"name": "Lauren", "rowid": 528514320239329281}}
where's the dog_id?
v19.2/change-data-capture.md, line 612 at r1 (raw file):
This will start up the changefeed in the background and return the `job_id`. The changefeed writes to Kafka. 14. In a new terminal, move into the extracted `confluent-<version>` directory and start watching the Kafka topic:
nit: topics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @danhhz and @piyush-singh)
v19.2/change-data-capture.md, line 428 at r1 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
where's the dog_id?
Added.
v19.2/change-data-capture.md, line 612 at r1 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
nit: topics
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed 4 of 6 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @danhhz and @piyush-singh)
Closes #6109