Skip to content

Conversation

lnhsingh
Copy link
Contributor

Closes #6109

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@lnhsingh lnhsingh changed the title Draft: Edit CDC examples to show more than one table in a changefeed Edit CDC examples to show more than one table in a changefeed Feb 10, 2020
@lnhsingh lnhsingh marked this pull request as ready for review February 10, 2020 21:32
@lnhsingh
Copy link
Contributor Author

cc @mwang1026

Copy link
Contributor

@danhhz danhhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @danhhz, @lnhsingh, and @piyush-singh)


v19.2/change-data-capture.md, line 428 at r1 (raw file):

    {"after": {"id": 1, "name": "Petee H"}}
    {"after": {"id": 2, "name": "Carl"}}
    {"after": {"name": "Lauren", "rowid": 528514320239329281}}

where's the dog_id?


v19.2/change-data-capture.md, line 612 at r1 (raw file):

    This will start up the changefeed in the background and return the `job_id`. The changefeed writes to Kafka.

14. In a new terminal, move into the extracted `confluent-<version>` directory and start watching the Kafka topic:

nit: topics

Copy link
Contributor Author

@lnhsingh lnhsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @danhhz and @piyush-singh)


v19.2/change-data-capture.md, line 428 at r1 (raw file):

Previously, danhhz (Daniel Harrison) wrote…

where's the dog_id?

Added.


v19.2/change-data-capture.md, line 612 at r1 (raw file):

Previously, danhhz (Daniel Harrison) wrote…

nit: topics

Done.

@ericharmeling ericharmeling requested a review from danhhz February 11, 2020 20:59
Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed 4 of 6 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @danhhz and @piyush-singh)

@lnhsingh lnhsingh merged commit c29b94e into master Feb 12, 2020
@lnhsingh lnhsingh deleted the multi-changefeeds branch February 12, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDC: recommend creating as few changefeeds as possible
4 participants