Skip to content

Rename more instances of blacklist/whitelist #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2020
Merged

Rename more instances of blacklist/whitelist #7535

merged 1 commit into from
Jun 20, 2020

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented Jun 20, 2020 •
edited
Loading

Fixes #7533.

Unfortunately, some instances reference functionality (flags, buttons, etc.) in third-party tools, for example:

$ ./bin/kafka-console-consumer \
    --bootstrap-server=localhost:9092 \
    --from-beginning \
    --whitelist 'office_dogs|employees'

We should open issues in those third-party repos to ask for these changes. In the case of Kafka, I'm not sure which repo to focus on (apache, confluent, etc.). @jordanlewis, to you have ideas?

@jseldess jseldess requested a review from Amruta-Ranade June 20, 2020 11:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/92f149c4aca9c67c591baceeac48eb1c1deaa4dc/

Edited pages:

Amruta-Ranade
Amruta-Ranade approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@Amruta-Ranade Amruta-Ranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jesse!

@jseldess jseldess merged commit 795882d into master Jun 20, 2020
@jseldess jseldess deleted the change-terminology branch June 20, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Amruta-Ranade Amruta-Ranade Amruta-Ranade approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove more instances of whitelist/blacklist
3 participants
@jseldess @cockroach-teamcity @Amruta-Ranade