Skip to content

Removed paragraph about SAVEPOINTs from run_transaction() recommendation #7793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

Removed paragraph about SAVEPOINTs from run_transaction() recommendation #7793

merged 1 commit into from
Aug 6, 2020

Conversation

ericharmeling
Copy link
Contributor

Fixes #6390.

@ericharmeling ericharmeling requested a review from rafiss July 27, 2020 18:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/37943fdbf2796e4cd7c3fe7396b59bc08c4fc105/

Edited pages:

@ericharmeling
Copy link
Contributor Author

@rafiss
Friendly review reminder :)

rafiss
rafiss approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks :)

@ericharmeling ericharmeling merged commit 026f4b9 into master Aug 6, 2020
@ericharmeling ericharmeling deleted the remove-savepoint-retry-para branch August 24, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update SQLAlchemy docs to remove incorrect info that SAVEPOINT is faster
3 participants
@ericharmeling @cockroach-teamcity @rafiss