Golang Hello World updates (PGX) #8991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ianjevans
suggested changes
Nov 25, 2020
| <section class="filter-content" markdown="1" data-scope="secure"> | ||
|
|
||
| ## Step 3. Create the `maxroach` user and `bank` database | ||
| ## Step 3. Start CockroachDB |
There was a problem hiding this comment.
I believe running go mod init below eliminates the need for Steps 1 & 2. All the library deps are resolved at that point.
ericharmeling
force-pushed
the
go-hw-updates
branch
from
4d643da to
74fef3e
Compare
ericharmeling
commented
Nov 30, 2020
There was a problem hiding this comment.
@ianjevans TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ianjevans)
v20.2/build-a-go-app-with-cockroachdb.md, line 35 at r1 (raw file):
Previously, ianjevans (Ian Evans) wrote…
I believe running
go mod initbelow eliminates the need for Steps 1 & 2. All the library deps are resolved at that point.
Done.
ianjevans
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/cockroachlabs/hello-world-go-pgx/pull/1.
Related to #8899.